optimization parseIP in xff #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1915 +/- ##
==========================================
+ Coverage 35.91% 43.74% +7.83%
==========================================
Files 69 78 +9
Lines 11576 12479 +903
==========================================
+ Hits 4157 5459 +1302
+ Misses 7104 6678 -426
- Partials 315 342 +27 🚀 New features to boost your workflow:
|
CH3CHO
reviewed
Mar 18, 2025
|
|
||
| if from_header { | ||
| source = strings.Trim(strings.Split(source, ",")[0], " ") | ||
| } |
There was a problem hiding this comment.
虽然可以用，但逻辑上是怪怪的，为什么 fromHeader 就需要先 split，来自别的地方就不需要呢？还是说逻辑上是因为某些来源的数据可能会包含多个值，需要做 split。是不是外部传一个 separator 更合适？如果separator 为空，就不做 split。
There was a problem hiding this comment.
按照之前代码逻辑也是只有从Header中获取的ip才进行split https://github.com/alibaba/higress/pull/1915/files#diff-7c4a88bf97556c8363af8dc954fe2bfa077fc5b0122a4349e6e52c5a5be5eee1L102-L106
其实应该是只有xff才支持多ip，需要做split操作，理论上remontAddr 和 real-ip 都不支持多ip(real-ip不是标准该规范)
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Forwarded-For
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimization parseIP in xff
xff 分割符为 [英文逗号+空格]，应该在提取后做trim操作（取第一个值其实理论没有问题）
parseIP函数中未支持多ip的处理，原有test case5中
127.0.0.1:12,[fe80::14d5:8aff:fed9:2114]:123是正好第一个ip带了端口才通过，如果是127.0.0.1,[fe80::14d5:8aff:fed9:2114]:123的话就会获取到127.0.0.1,[fe80的结果Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews