ListAttribute: fix methods not considering connected attribute's value #2660
+68
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `__len__`, `__iter__`, `at` and `index` to consider linked ListAttribute value when it is connected.
yann-lty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2660 +/- ##
===========================================
+ Coverage 69.96% 70.12% +0.16%
===========================================
Files 121 122 +1
Lines 7084 7119 +35
===========================================
+ Hits 4956 4992 +36
+ Misses 2128 2127 -1 ☔ View full report in Codecov by Sentry. |
yann-lty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix ListAttribute methods not considering linked ListAttribute value when connected.
Features list
__len__,__iter__,atandindexmethods to consider linked value.Implementation remarks
Use
valueproperty in those methods, that will consider the linked ListAttribute value if the attribute is connected.