Fixes divide by zero events on the study view page

alisman · Jan 3, 2022 · ad8f6f5 · ad8f6f5
1 parent d7b33c5
commit ad8f6f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/service/src/main/java/org/cbioportal/service/util/ProfiledCasesCounter.java b/service/src/main/java/org/cbioportal/service/util/ProfiledCasesCounter.java
@@ -94,7 +94,10 @@ public void calculate(List<T> alterationCounts,
                     alterationCountByGene.setNumberOfProfiledCases(totalProfiledSamples);
                 }
             } else {
-                alterationCountByGene.setNumberOfProfiledCases(casesWithoutPanelData.size());
+                // we use profiledCasesCount instead of casesWithoutPanelData to
+                // prevent a divide by zero error which can happen for targeted studies
+                // in which certain genes have events that are not captured by the panel.
+                alterationCountByGene.setNumberOfProfiledCases(profiledCasesCount);
             }
             alterationCountByGene.setMatchingGenePanelIds(allMatchingGenePanelIds);
         }

diff --git a/service/src/test/java/org/cbioportal/service/util/ProfiledCasesCounterTest.java b/service/src/test/java/org/cbioportal/service/util/ProfiledCasesCounterTest.java
@@ -106,21 +106,21 @@ public void calculate() throws Exception {
 
         Assert.assertEquals(Integer.valueOf(3), alterationCounts.get(0).getNumberOfProfiledCases());
         Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(1).getNumberOfProfiledCases());
-        Assert.assertEquals(Integer.valueOf(1), alterationCounts.get(2).getNumberOfProfiledCases());
+        Assert.assertEquals(Integer.valueOf(3), alterationCounts.get(2).getNumberOfProfiledCases());
 
 
         profiledSamplesCounter.calculate(alterationCounts, genePanelDataList, false, profiledSamplesCounter.patientUniqueIdentifier);
 
         Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(0).getNumberOfProfiledCases());
         Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(1).getNumberOfProfiledCases());
-        Assert.assertEquals(Integer.valueOf(1), alterationCounts.get(2).getNumberOfProfiledCases());
+        Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(2).getNumberOfProfiledCases());
 
         profiledSamplesCounter.calculate(alterationCounts, genePanelDataList, true, profiledSamplesCounter.patientUniqueIdentifier);
 
         Assert.assertEquals(4, alterationCounts.size());
         Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(0).getNumberOfProfiledCases());
         Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(1).getNumberOfProfiledCases());
-        Assert.assertEquals(Integer.valueOf(1), alterationCounts.get(2).getNumberOfProfiledCases());
+        Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(2).getNumberOfProfiledCases());
         Assert.assertEquals(Integer.valueOf(2), alterationCounts.get(3).getNumberOfProfiledCases());
         Assert.assertEquals(Integer.valueOf(4), alterationCounts.get(3).getEntrezGeneId());