Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:多标签的图标与名称无间距问题修复 #660

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rongxingsun
Copy link

No description provided.

Copy link

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: a4ac71a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alita-alita ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 2:26am

@rongxingsun rongxingsun changed the title 多标签的图标与名称无间距问题修复 fix:多标签的图标与名称无间距问题修复 Jul 24, 2024
@xiaohuoni
Copy link
Member

antd@4 呢?

@rongxingsun
Copy link
Author

antd4没遇到这个问题

@xiaohuoni
Copy link
Member

antd4没遇到这个问题

嗯,我是说,你这么改之后,在 antd@4 还能跑吗?

@rongxingsun
Copy link
Author

antd4没遇到这个问题

嗯,我是说,你这么改之后,在 antd@4 还能跑吗?

可以正常跑

@@ -442,7 +442,8 @@ export function useKeepOutlets() {
{...tabProps}
{{#isNewTabsAPISupported}}
items={Object.entries(keepElements.current).map(([pathname, {name, icon, closable, children, ...other}]: any) => ({
label: <>{icon}{name}</>,
label: name,
icon: icon,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

冒号是中文

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants