Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an External ID param on RAM Role Authentication #1153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ihar-orca
Copy link

@ihar-orca ihar-orca commented Dec 2, 2024

Hey guys, we want to contribute an ability to use external_id on RAM Role Authentication.
@sdk-team

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ihar-orca ihar-orca changed the title CVO-17 Add an External ID param on RAM Role Authentication Add an External ID param on RAM Role Authentication Dec 2, 2024
@yndu13
Copy link

yndu13 commented Dec 6, 2024

Hi ihar-orca,

First and foremost, thank you very much for your contribution! We really appreciate the effort you've put into adding the ability to use external_id on RAM Role Authentication.

However, I noticed that there is a test case that hasn't passed. I've attached a screenshot of the error for your reference. Since you have already written some test cases, could you please take a look and update the failing one? If for any reason you are unable to make the changes, we would be happy to assist and make the updates on our end.

image

Thanks again for your valuable contribution!

Best regards,

sdk-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants