Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor credentials providers && add provider name #94

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

yndu13
Copy link
Collaborator

@yndu13 yndu13 commented Nov 19, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@yndu13 yndu13 force-pushed the providers branch 2 times, most recently from 3d17295 to e034792 Compare November 19, 2024 12:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 85.35980% with 59 lines in your changes missing coverage. Please review.

Project coverage is 91.43%. Comparing base (3d71454) to head (b940604).

Files with missing lines Patch % Lines
...ntials/provider/OIDCRoleArnCredentialProvider.java 71.73% 6 Missing and 7 partials ⚠️
...ntials/provider/CLIProfileCredentialsProvider.java 92.30% 2 Missing and 8 partials ⚠️
...edentials/provider/ProfileCredentialsProvider.java 77.77% 8 Missing ⚠️
...n/java/com/aliyun/credentials/utils/AuthUtils.java 75.00% 4 Missing and 2 partials ⚠️
...provider/ECSMetadataServiceCredentialsFetcher.java 72.22% 1 Missing and 4 partials ⚠️
...entials/provider/EcsRamRoleCredentialProvider.java 70.58% 4 Missing and 1 partial ⚠️
...entials/provider/RsaKeyPairCredentialProvider.java 84.37% 1 Missing and 4 partials ⚠️
...entials/provider/RamRoleArnCredentialProvider.java 91.48% 1 Missing and 3 partials ⚠️
...edentials/provider/DefaultCredentialsProvider.java 87.50% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
+ Coverage     91.37%   91.43%   +0.06%     
- Complexity      613      714     +101     
============================================
  Files            45       46       +1     
  Lines          2202     2359     +157     
  Branches        169      213      +44     
============================================
+ Hits           2012     2157     +145     
  Misses          128      128              
- Partials         62       74      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yndu13 yndu13 force-pushed the providers branch 7 times, most recently from b6bd15f to f577018 Compare November 23, 2024 14:01
@yndu13 yndu13 merged commit e1c991c into master Nov 25, 2024
4 checks passed
@yndu13 yndu13 deleted the providers branch November 25, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants