Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade the credential refresh mechanism and add fallbacks for … #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yndu13
Copy link
Collaborator

@yndu13 yndu13 commented Dec 3, 2024

…error scenarios

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 58.64979% with 98 lines in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (e1c991c) to head (1556b04).

Files with missing lines Patch % Lines
...un/credentials/provider/RefreshCachedSupplier.java 40.24% 43 Missing and 6 partials ⚠️
...ava/com/aliyun/credentials/policy/NonBlocking.java 33.33% 12 Missing ⚠️
...entials/provider/EcsRamRoleCredentialProvider.java 73.52% 6 Missing and 3 partials ⚠️
...com/aliyun/credentials/provider/RefreshResult.java 46.15% 7 Missing ⚠️
...com/aliyun/credentials/policy/OneCallerBlocks.java 33.33% 4 Missing ⚠️
...provider/ECSMetadataServiceCredentialsFetcher.java 60.00% 1 Missing and 3 partials ⚠️
...edentials/provider/SessionCredentialsProvider.java 60.00% 4 Missing ⚠️
...un/credentials/provider/URLCredentialProvider.java 75.00% 2 Missing and 2 partials ⚠️
.../com/aliyun/credentials/utils/ParameterHelper.java 93.10% 2 Missing ⚠️
...com/aliyun/credentials/models/CredentialModel.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     91.43%   89.09%   -2.35%     
- Complexity      714      725      +11     
============================================
  Files            46       49       +3     
  Lines          2359     2513     +154     
  Branches        213      220       +7     
============================================
+ Hits           2157     2239      +82     
- Misses          128      197      +69     
- Partials         74       77       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants