Use public endpoint for Kube config if public access enabled #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
leonrodenburg
force-pushed
the
public-k8s-endpoint
branch
from
8f413ba to
2c3a5a5
Compare
|
@xiaozhu36 Any chance this could get merged? Really need this :) |
leonrodenburg
force-pushed
the
public-k8s-endpoint
branch
from
2c3a5a5 to
3a5b820
Compare
|
Léon Rodenburg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading a serverless K8s cluster, there was a boolean logic error that caused private IP addresses to be set in the Kube config file when public API access is enabled. This PR fixes the logic so a public IP is set in the Kube config YAML when public access is enabled, and uses a private IP if public access is disabled.
Also pushed in a fix to not recreate a cluster when the paths to the Kube config or certs is updated. As these properties are only used in
resourceAlicloudCSServerlessKubernetesRead(), where the config is queried and then written to the specified paths on disk, there is no way that changing the path will ever affect the cluster in any way. Completely ditching and recreating the cluster seems like overkill for this.