Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_network_interfaces #2479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix_network_interfaces #2479

wants to merge 1 commit into from

Conversation

juhuahaoteng
Copy link
Contributor

fix_network_interfaces

@juhuahaoteng juhuahaoteng force-pushed the fix_network_interfaces branch 2 times, most recently from a86604e to 1397cfd Compare May 29, 2020 07:42
@juhuahaoteng juhuahaoteng force-pushed the fix_network_interfaces branch from 1397cfd to 32eb150 Compare June 1, 2020 06:54
xiaozhu36
xiaozhu36 requested changes Aug 10, 2020
View reviewed changes
alicloud/data_source_alicloud_network_interfaces.go
@@ -65,6 +65,7 @@ func dataSourceAlicloudNetworkInterfaces() *schema.Resource {
Type: schema.TypeList,
Elem: &schema.Schema{Type: schema.TypeString},
Computed: true,
Optional: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to set names to an input parameter and can use name_regex instead.

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhu36 xiaozhu36 xiaozhu36 requested changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juhuahaoteng @CLAassistant @xiaozhu36