modify cen_bandwidth_package #2677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
SanfordLuo
force-pushed
the
cen_bandwidth_package
branch
from
4da47a8 to
eef8bdd
Compare
zql-tqy
reviewed
Jul 29, 2020
| @@ -36,6 +36,8 @@ The following arguments are supported: | |||
| * `description` - (Optional) The description of the bandwidth package. Default to null. | |||
| * `charge_type` - (Optional) The billing method. Valid value: PostPaid | PrePaid. Default to PostPaid. If set to PrePaid, the bandwidth package can't be deleted before expired time. | |||
| * `period` - (Optional) The purchase period in month. Valid value: 1, 2, 3, 6, 12. Default to 1. | |||
| * `auto_renew` - (Optional) Whether to renew a bandwidth package automatically or not. It is valid when `charge_type` is PrePaid. Valid value: true, false. Default to false. | |||
There was a problem hiding this comment.
(Optional, Available in 1.92.0+) default 的值使用反引号特殊标记下，下面也是一样
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Default: false, | ||
| DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool { |
There was a problem hiding this comment.
这个两个参数没有支持更新的 update 方法，所以这两个参数应该是 forcenew 的吧，如果是在文档中也要标记下
SanfordLuo
force-pushed
the
cen_bandwidth_package
branch
from
eef8bdd to
45bc5db
Compare
SanfordLuo
force-pushed
the
cen_bandwidth_package
branch
from
45bc5db to
7ffd2df
Compare
|
SanfordLuo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
xiaozhu36
requested changes
Oct 15, 2020
| Default: false, | ||
| ForceNew: true, | ||
| DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool { | ||
| return PayType(d.Get("charge_type").(string)) == PrePaid |
There was a problem hiding this comment.
I think the line 89 should be PayType(d.Get("charge_type").(string)) == PostPaid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.