Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to bgp-peer, bgp-network, bgp-group #2715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhengjc2018
Copy link
Contributor

No description provided.

@zhengjc2018 zhengjc2018 force-pushed the add_bgp branch 5 times, most recently from 09634c5 to f9c3331 Compare August 12, 2020 07:55
request.RouterId = d.Get("router_id").(string)
request.ClientToken = buildClientToken(request.GetActionName())

if v, ok := d.GetOk("is_fake_asn"); ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool 类型的值使用 d.GetOkExists 获取

return resp, nil
}
}
return v, WrapErrorf(Error(GetNotFoundMessage("BgpNetwork", id)), NotFoundMsg, ProviderERROR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return v, WrapErrorf(Error(GetNotFoundMessage("BgpNetwork", id)), NotFoundMsg, ProviderERROR, response.RequestId)
如果资源查找不到将 requestId 输出,在 read 方法中打印到 log 中


-> **NOTE:** Terraform will auto build bgp group instance while it uses `alicloud_bgp_group` to build a bgp group resource.

-> **NOTE:** Available in v1.91.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.94.0.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants