add edas_k8s_application. #2729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Heleninsa
force-pushed
the
edas-k8s-app
branch
from
c027d0a to
25c79f2
Compare
Heleninsa
force-pushed
the
edas-k8s-app
branch
from
36c66bb to
1ecb3c6
Compare
chushenmeshile
suggested changes
Oct 15, 2020
| if response.Code != 200 { | ||
| return WrapError(Error("Create k8s application failed for " + response.Message)) | ||
| } | ||
|
|
There was a problem hiding this comment.
d.setId 是不是应该放到response.code的下面
| } | ||
| if d.Get("package_type") == "Image" { | ||
| d.Set("image_url", response.ImageInfo.ImageUrl) | ||
| } |
There was a problem hiding this comment.
确定其他schema中的参数，describe方法没有返回值
package_type 为FatJar, War时，属性不写入state文件吗
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheck(map[string]string{ | ||
| "application_name": name, | ||
| "replicas": "1", |
There was a problem hiding this comment.
package_type和image_url也需要check
| "application_name": CHECKSET, | ||
| "replicas": "1", | ||
| "image_url": CHECKSET, | ||
| }), |
| "replicas": CHECKSET, | ||
| "package_type": CHECKSET, | ||
| } | ||
|
|
There was a problem hiding this comment.
application_name，replicas，package_type checkset 可以去掉吧
| @@ -31,7 +31,7 @@ func resourceAlicloudEdasK8sCluster() *schema.Resource { | |||
| "namespace_id": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| ForceNew: true, | |||
| Computed: true, | |||
| }, | |||
| Create an EDAS k8s application. | ||
|
|
||
| -> **NOTE:** Available in 1.92.0+ | ||
|
|
| Basic Usage | ||
|
|
||
| ``` | ||
| resource "alicloud_edas_k8s_application" "default" { |
| * `replicas` - Number of application instances. | ||
| * `package_type` - Application package type. Optional parameter values include: FatJar, WAR and Image. | ||
| * `image_url` - Mirror address. When the package_type is set to 'Image', this parameter item is available. | ||
|
|
|
|
||
| ``` | ||
| $ terraform import alicloud_edas_k8s_application.new_k8s_application application_id | ||
| ``` |
There was a problem hiding this comment.
new_k8s_application和文档保持一致写default,id用字母数字星号组合
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.