Edas k8s dep. depend on previous pull request: edas-k8s-app #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zql-tqy
reviewed
Aug 21, 2020
alicloud/resource_alicloud_edas_k8s_application_package_attachment.go
Outdated
Show resolved
Hide resolved
website/docs/r/edas_k8s_application_package_attachment.html.markdown
Outdated
Show resolved
Hide resolved
zql-tqy
reviewed
Aug 21, 2020
alicloud/resource_alicloud_edas_k8s_application_package_attachment_test.go
Outdated
Show resolved
Hide resolved
|
Test result:
|
zql-tqy
reviewed
Aug 26, 2020
alicloud/resource_alicloud_edas_k8s_application_package_attachment.go
Outdated
Show resolved
Hide resolved
alicloud/resource_alicloud_edas_k8s_application_package_attachment_test.go
Outdated
Show resolved
Hide resolved
liuri1205
reviewed
Sep 3, 2020
zql-tqy
reviewed
Sep 10, 2020
|
|
||
| Create an EDAS k8s application.For information about EDAS K8s Application and how to use it, see [What is EDAS K8s Application](https://www.alibabacloud.com/help/doc-detail/85029.htm). | ||
|
|
||
| -> **NOTE:** Available in 1.95.0+ |
| @@ -967,10 +967,12 @@ | |||
| <li> | |||
| <a href="/docs/providers/alicloud/r/edas_k8s_cluster.html">alicloud_edas_k8s_cluster</a> | |||
| </li> | |||
| <li> | |||
| <a href="/docs/prodivers/alicloud/r/edas_k8s_application.html">alicloud_edas_k8s_application</a> | |||
| } | ||
| } | ||
|
|
||
| func resourceAlicloudEdasK8sApplicationUpdate(d *schema.ResourceData, meta interface{}) error { |
There was a problem hiding this comment.
这个 update 接口和 create 调整下顺序，另外这个 update 接口逻辑是有问题的，我们在 update 中使用 d.hasChange 去判断该属性是否有变化，如果所有属性都没有变化的话是不需要调用 update 接口的；update 中还需要使用 IsNewResource 判断是否是 Create 之后的新资源，如果是的话，在 Create 中设置的参数就不需要在 新资源 的 update 中进行设置了，这个可以参考 kvstore_instance 的写法；
| testAccCheck(map[string]string{ | ||
| "image_url": updateImg, | ||
| "replicas": "3", | ||
| }), |
There was a problem hiding this comment.
支持变更的参数都要在 test case 中进行变更测试；
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.