feature white list for separated status routes #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozjan
reviewed
Mar 7, 2025
.../allegro/tech/servicemesh/envoycontrol/snapshot/resource/routes/EnvoyIngressRoutesFactory.kt
Outdated
Show resolved
Hide resolved
kozjan
reviewed
Mar 7, 2025
...egro/tech/servicemesh/envoycontrol/snapshot/resource/routes/EnvoyIngressRoutesFactoryTest.kt
Outdated
Show resolved
Hide resolved
kozjan
reviewed
Mar 7, 2025
...egro/tech/servicemesh/envoycontrol/snapshot/resource/routes/EnvoyIngressRoutesFactoryTest.kt
Outdated
Show resolved
Hide resolved
Ferdudas97
force-pushed
the
whitelist-for-status-endpoints
branch
from
283152e to
f04810f
Compare
kozjan
reviewed
Mar 7, 2025
|
|
||
| @Test | ||
| @Suppress("LongMethod") | ||
| fun `should create not create routes for status endpoints if the service is not whitelisted`() { |
There was a problem hiding this comment.
Suggested change
| fun `should create not create routes for status endpoints if the service is not whitelisted`() { | |
| fun `should not create routes for status endpoints if the service is not whitelisted`() { |
|
|
||
| @Test | ||
| @Suppress("LongMethod") | ||
| fun `should create create routes for status endpoints when whitelist contains wildcard`() { |
There was a problem hiding this comment.
Suggested change
| fun `should create create routes for status endpoints when whitelist contains wildcard`() { | |
| fun `should create routes for status endpoints when whitelist contains wildcard`() { |
| hasOnlyRoutesInOrder( | ||
| *adminRoutes, | ||
| { | ||
| ingresStatusRoute() |
There was a problem hiding this comment.
not necessary: ingresStatusRoute > ingressStatusRoute
|
also another nitpick - white list > whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introudced white list for separated routes for status endpoints to provide gradual rollout, also refactored a code to use existing properties