removed unnecessary empty line + improvements

allegro · Jan 23, 2025 · 3a96008 · 3a96008
1 parent 6de1bcc
commit 3a96008
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/hermes-console/json-server/db.json b/hermes-console/json-server/db.json
@@ -177,7 +177,7 @@
       },
       "jsonToAvroDryRun": false,
       "ack": "LEADER",
-      "fallbackToRemoteDatacenterEnabled": false,
+      "fallbackToRemoteDatacenterEnabled": true,
       "trackingEnabled": false,
       "migratedFromJsonType": false,
       "schemaIdAwareSerializationEnabled": false,

diff --git a/hermes-console/json-server/topics.json b/hermes-console/json-server/topics.json
@@ -16,7 +16,7 @@
     "ack": "LEADER",
     "trackingEnabled": false,
     "migratedFromJsonType": false,
-    "fallbackToRemoteDatacenterEnabled": false,
+    "fallbackToRemoteDatacenterEnabled": true,
     "schemaIdAwareSerializationEnabled": false,
     "contentType": "AVRO",
     "maxMessageSize": 10240,

diff --git a/hermes-console/src/i18n/en-US/index.ts b/hermes-console/src/i18n/en-US/index.ts
@@ -326,7 +326,7 @@ const en_US = {
       creationDate: 'Creation date',
       modificationDate: 'Modification date',
       fallbackToRemoteDatacenterEnabled:
-        'Fallback to remote datacenter enabled',
+        'Fallback to remote DC enabled',
       tooltips: {
         acknowledgement:
           'Specifies the strength of guarantees that acknowledged message was indeed persisted. ' +
@@ -347,7 +347,7 @@ const en_US = {
         offlineRetention:
           'For how long should this topic be stored in offline storage.',
         fallbackToRemoteDatacenterEnabled:
-          'In case of failure, Hermes fallback to remote datacenter instead of store unsent messages in offline storage. Enabling fallback to remote DC increase messages durability but may increase publishing latency.',
+          'In case of message publishing failure, Hermes fallback to a remote DC instead of store unsent messages in offline storage. Enabling fallback to remote DC increase your messages durability but may impact publishing latency.',
       },
       ackText: {
         all: 'All brokers',

diff --git a/hermes-console/src/i18n/en-US/topic-form.ts b/hermes-console/src/i18n/en-US/topic-form.ts
@@ -32,7 +32,7 @@ const messages = {
       days: 'DAYS',
     },
     ack: 'Kafka ACK level',
-    fallbackToRemoteDatacenterEnabled: 'Fallback to remote datacenter enabled',
+    fallbackToRemoteDatacenterEnabled: 'Fallback to remote DC enabled',
     ackHelpTitle: 'ACK level is very important',
     ackHelpText:
       'Set ACK level according to your durability and latency requirements, see: ',

diff --git a/...c/main/java/pl/allegro/tech/hermes/consumers/consumer/sender/http/HttpClientsFactory.java b/...c/main/java/pl/allegro/tech/hermes/consumers/consumer/sender/http/HttpClientsFactory.java
@@ -38,7 +38,6 @@ public HttpClient createClientForHttp1(String name, Http1ClientParameters http1C
         client.setMaxRequestsQueuedPerDestination(http1ClientParameters.getMaxRequestsQueuedPerDestination());
         client.setHttpCookieStore(new HttpCookieStore.Empty());
         client.setIdleTimeout(http1ClientParameters.getIdleTimeout().toMillis());
-
         client.setFollowRedirects(http1ClientParameters.isFollowRedirectsEnabled());
         client.setConnectTimeout(http1ClientParameters.getConnectionTimeout().toMillis());
         return client;