TANGO 2130 #1903
Merged
TANGO 2130 #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adamallegro
commented
Sep 24, 2024
adamallegro
commented
- TANGO-2130 : Tests for primitive types
- TANGO-2130 : Array and Map primitives - tests
- TANGO-2130 : Checkpoint after primitives
- TANGO-2130 : Unit tests for records and for simple type mappings
- TANGO-2130 : Updated and refactored tests
wikp
reviewed
Sep 27, 2024
| if (value instanceof Boolean) { | ||
| return value; | ||
| } else if (value instanceof Number) { | ||
| return ((Number) value).intValue() > 0; |
There was a problem hiding this comment.
Is it really how the int field should be casted to boolean? I would have used ((Number) value).intValue() != 0
wikp
reviewed
Sep 27, 2024
| return new Schema.Parser().parse(AvroTrait.class.getClassLoader().getResourceAsStream("schemas/${fileName}.avsc")) | ||
| } | ||
|
|
||
| GenericRecord getGenericRecordFromFile(String payloadFile, Schema schema) { |
There was a problem hiding this comment.
I don't think you use this method in the code here as it's intended to read .avro files without headers.
wikp
reviewed
Sep 27, 2024
|
|
||
| where: | ||
| suite | avroType | protoDescriptor | avroValue | expectedProtoValue | transformResult | ||
| "primitives" | "string" | StringProto.PrimitivesString.getDescriptor() | "value" | "value" | { c -> c } |
There was a problem hiding this comment.
Why do you need transformResult variable if all provided values are the same (identity func)?
wikp
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.