-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Account helpers #1717
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, I like this,
could we also add these tests:
Got it, I'll add them 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, now that I looked at this,
it would be easier if we upstream this to alloy-trie entirely
the trieaccount type + state root functions
could you please open these changes as a pr to alloy-trie
then we import alloy-trie in alloy-genesis and to the from impl there
Ah, that makes sense. I'll work on it! |
@mattsse |
Motivation
TrieAccount
in Reth will be replaced withAccount
from alloy, so it would be better forTrieAccount
related helpers to be exported to alloy.paradigmxyz/reth#12318
https://github.com/paradigmxyz/reth/blob/c8e5b233ef242c4c5eaebe6dc5ae66b98184d8a8/crates/trie/common/src/root.rs#L10-L36
Also implements
From<GenesisAccount>
forAccount
since Reth needs it infn state_root_ref_unhashed<'a, A: Into<Account> + Clone + 'a>
Solution
PR Checklist