Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consensus): public RlpEcdsaTx #1720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(consensus): public RlpEcdsaTx #1720

wants to merge 2 commits into from

Conversation

htiennv
Copy link

@htiennv htiennv commented Nov 30, 2024

Description

Public trait RlpEcdsaTx for implementation of OpTypedTransaction.

Ref: alloy-rs/op-alloy#316

mattsse
mattsse requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can re-export but I'd like to use a separete pub use and mark this as doc(hidden) because this is considered private API and should only be used by other network impl like op-alloy, if we really need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse requested changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htiennv @mattsse