feat: Migrate to TrieAccount of alloy-trie
#1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moricho
requested review from
DaniPopes,
gakonst,
mattsse and
onbjerg
as code owners
moricho
commented
Dec 4, 2024
| @@ -9,8 +9,7 @@ | |||
|
|
|||
| extern crate alloc; | |||
|
|
|||
| mod account; | |||
| pub use account::Account; | |||
| pub use alloy_trie::TrieAccount as Account; | |||
There was a problem hiding this comment.
Re-exported TrieAccount as Account in alloy-consensus for the compatibility
There was a problem hiding this comment.
can we also re-export TrieAccount and mark this rename as deprecated?
moricho
changed the title
TrieAccount from alloy-trieTrieAccount of alloy-trie
mattsse
requested changes
Dec 4, 2024
| @@ -9,8 +9,7 @@ | |||
|
|
|||
| extern crate alloc; | |||
|
|
|||
| mod account; | |||
| pub use account::Account; | |||
| pub use alloy_trie::TrieAccount as Account; | |||
There was a problem hiding this comment.
can we also re-export TrieAccount and mark this rename as deprecated?
mattsse
approved these changes
Dec 4, 2024
|
@mattsse I just saw your comment. Thank you for handling the genesis account conversion! |
|
thank you! I quickly pushed this over the line because we needed a new release on reth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Accounthas been migrated toTrieAccountof alloy-trie in alloy-rs/trie#65Solution
PR Checklist