chore: remove associated constant from RlpEcdsaEncodableTx #2172
+25
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
mattsse
requested changes
Mar 11, 2025
| @@ -195,8 +195,8 @@ pub trait RlpEcdsaDecodableTx: RlpEcdsaEncodableTx { | |||
|
|
|||
| /// Decodes the transaction from eip2718 bytes, expecting the default type | |||
| /// flag. | |||
| fn eip2718_decode(buf: &mut &[u8]) -> Eip2718Result<Signed<Self>> { | |||
| Self::eip2718_decode_with_type(buf, Self::DEFAULT_TX_TYPE) | |||
| fn eip2718_decode(&self, buf: &mut &[u8]) -> Eip2718Result<Signed<Self>> { | |||
There was a problem hiding this comment.
we can't give the decoding fns a &self arg because this defeats the purpose of decoding, so we need to fix this separately
| /// The default transaction type for this transaction. | ||
| const DEFAULT_TX_TYPE: u8; | ||
|
|
||
| pub trait RlpEcdsaEncodableTx: Sized + Typed2718 { |
| } | ||
| } | ||
|
|
||
| /// Helper trait for managing RLP decoding of transactions inside 2718 envelopes. | ||
| #[doc(hidden)] | ||
| #[doc(alias = "RlpDecodableTx", alias = "RlpTxDecoding")] | ||
| pub trait RlpEcdsaDecodableTx: RlpEcdsaEncodableTx { | ||
| pub trait RlpEcdsaDecodableTx: RlpEcdsaEncodableTx + Typed2718 { |
There was a problem hiding this comment.
here we now need to introduce the associated constant for now, because we can't remove that in one go, but we want to remove it from the encodable trait right away
stevencartavia
changed the title
3 tasks
3 tasks
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Mar 12, 2025
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation same as alloy-rs/alloy#2172 <!-- Explain the context and why you're making that change. What is the problem you're trying to solve? In some cases there is not a problem and this can be thought of as being the motivation for your change. --> ## Solution <!-- Summarize the solution and provide any necessary context needed to understand the code change. --> ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes --------- Co-authored-by: Matthias Seitz <[email protected]>
|
Hey, couldn't help but notice this API breaking change was included in the patch release |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #2171
Solution
PR Checklist