Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallets): add keystore example #17

Merged
merged 8 commits into from
Mar 25, 2024
Merged

feat(wallets): add keystore example #17

merged 8 commits into from
Mar 25, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Mar 25, 2024 •
edited
Loading

Closes #15

  • Adds a keystore_signer example of signing using an existing keystore file
  • Adds a create_keystore example showing how to create a keystore file - this is in line with the existing sign_message and sign_permit_hash of showing a practical use case

mattsse
mattsse requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nits

examples/wallets/examples/create_keystore.rs Outdated Show resolved Hide resolved
examples/wallets/examples/keystore_signer.rs Outdated Show resolved Hide resolved
@zerosnacks zerosnacks requested a review from mattsse March 25, 2024 14:07
@zerosnacks zerosnacks merged commit f2c7292 into main Mar 25, 2024
2 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/add-keystore-example branch March 25, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg left review comments

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add KeyStore signer example
3 participants
@zerosnacks @onbjerg @mattsse