Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): Remove re-export of maili traits #386

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

emhane
Copy link
Collaborator

@emhane emhane commented Jan 14, 2025

Removes re-export of maili deposit traits, to avoid error
note: there are multiple different versions of crate maili_common in the dependency graph

@emhane emhane added the C-deps Category: Dependencies label Jan 14, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: there are multiple different versions of crate maili_common in the dependency graph

this is because we still have a circular dep graph across the repo
I'd really prefer if we could get rid of this

@emhane
Copy link
Collaborator Author

emhane commented Jan 14, 2025

note: there are multiple different versions of crate maili_common in the dependency graph

this is because we still have a circular dep graph across the repo I'd really prefer if we could get rid of this

yepp, aware of this. we are almost done getting rid of last dep op-alloy-consensus. apologies for the construction site.

@emhane emhane changed the base branch from main to emhane/bump-maili January 14, 2025 21:15
@emhane emhane merged commit 5e91f82 into emhane/bump-maili Jan 14, 2025
13 of 19 checks passed
@emhane emhane deleted the emhane/fix-tx-deposit branch January 14, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-deps Category: Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants