Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flz #400

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: add flz #400

merged 1 commit into from
Jan 22, 2025

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 22, 2025

adds standalone flz repo

this could eventually be converted into a standalone crate, if revm is willing to import that and remove code dup

@clabby
Copy link
Collaborator

clabby commented Jan 22, 2025

LGTM.

We'd also like to have revm-optimism (which is a standalone crate, post-refactor on revm's main branch) consume maili for the L1Block type. What do you think about that? Right now it has its own, duplicated impl.

We discussed with Dragan last week, and he said it was fine, so long as we moved the revm-optimism crate outside of the revm repository.

@mattsse
Copy link
Member Author

mattsse commented Jan 22, 2025

you we faced some opposition getting standalone alloy deps included in revm, if this would be a standalone thing then this would be easier

@mattsse mattsse added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 33b99e2 Jan 22, 2025
20 checks passed
@mattsse mattsse deleted the matt/add-flz branch January 22, 2025 14:48
@clabby
Copy link
Collaborator

clabby commented Jan 22, 2025

you we faced some opposition getting standalone alloy deps included in revm, if this would be a standalone thing then this would be easier

Sounds good - yeah, we covered that. The idea was as you said, if it's a standalone extension, it's less of a big deal + won't impact the release flow for L1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants