-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #893 - param annotation name not coming up in report #1130
Open
mr-possible
wants to merge
1
commit into
allure-framework:main
Choose a base branch
from
mr-possible:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baev
requested changes
Sep 25, 2024
allure-testng/src/test/java/io/qameta/allure/testng/samples/ParameterizedTest.java
Outdated
Show resolved
Hide resolved
baev
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use wildcard imports. Otherwise — great job 👍
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
Outdated
Show resolved
Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java
Outdated
Show resolved
Hide resolved
baev
approved these changes
Sep 26, 2024
mr-possible
force-pushed
the
main
branch
2 times, most recently
from
November 3, 2024 15:59
b4cd9ad
to
603bd6f
Compare
hey @baev , can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893
Context
Before fix:
After fix:
Checklist