Fix build on MacOS #2
Closed
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelshmitty
commented
Aug 17, 2023
| @@ -335,6 +335,7 @@ pub fn build(b: *std.Build) void { | |||
| "-DHAVE_CONFIG_H", | |||
| "-std=c17", | |||
| "-Wno-implicit-function-declaration", | |||
| "-Wno-int-conversion", | |||
There was a problem hiding this comment.
Clang output a whole bunch of warnings that were turned into errors and made the build fail if I didn't disable these warnings. Not a fan of having to disable warnings though, maybe there's a better way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes some config flags dynamically based on the target os. It fixes some build errors on MacOS regarding the inclusion of
endian.hon that platform. May need to do the same for Windows platform, but haven't set up that environment yet.Eager to learn from this, so please let me know your thoughts if you have the time. Thanks!
Related to allyourcodebase/ffmpeg#6