Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cdn for alma widget and update to version 4.x.x #322

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task
Linear task

Code changes

Implementation of the CDN for the Alma widget and update it to version 4.x.x

How to test

As a reviewer, you are encouraged to test the PR locally.
You can run unit tests and E2E.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested a review from a team as a code owner February 7, 2025 09:59

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Francois-Gomis
Copy link
Collaborator

I think build is made from a start not a build. Build is doesn't seem minified.

includes/Handlers/GenericHandler.php Outdated Show resolved Hide resolved
includes/Handlers/GenericHandler.php Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 7, 2025

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

Copy link

github-actions bot commented Feb 7, 2025

❌ E2E tests have failed.
➡️ You can find the results here.

@joyet-simon joyet-simon requested a review from webaaz February 7, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants