-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iphone 12 ratio changed #193
base: master
Are you sure you want to change the base?
Conversation
@@ -26,7 +26,7 @@ apply plugin: 'kotlin-android' | |||
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle" | |||
|
|||
android { | |||
compileSdkVersion 30 | |||
compileSdkVersion 31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR is about the iPhone 12 ratio. Please exclude unrelated changes such as this one.
@@ -1,5 +1,5 @@ | |||
buildscript { | |||
ext.kotlin_version = '1.3.50' | |||
ext.kotlin_version = '1.6.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR is about the iPhone 12 ratio. Please exclude unrelated changes such as this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the changes in device.dart
look good to me, you should try to only commit changes related to your PR.
Send a PR referring to the code of "ChangJoo-Park", the author of "iPhone 12 has wrong size" in the issue section.
Thank you to "ChangJoo-Park".