Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernising the entire project #225

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

bradrushworth
Copy link

sdk: '>=2.18.4 <3.0.0'
added new device "Pixel 4" #195
Fix a typo in the documentation #201
Corrects the iPhone 12 screen size and safe area #204
Bump intl to v.0.18.0 #222

@bradrushworth
Copy link
Author

Feel free to use this update by adding to your pubspec.yaml

dependency_overrides:
  device_preview:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_preview
#    path: ../flutter_device_preview/device_preview
  device_frame:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_frame
#    path: ../flutter_device_preview/device_frame

@mikhael28
Copy link

This is a sweet update! I hope the author merges it in

@wer-mathurin
Copy link

@aloisdeniel: this plugin is awesome, but need some love in terms of accepting PR. PRs that make it compatible with the latest and greatest flutter release and devices seems very helpful. Any timeframe to review this PR?

@Princewil
Copy link

Feel free to use this update by adding to your pubspec.yaml

dependency_overrides:
  device_preview:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_preview
#    path: ../flutter_device_preview/device_preview
  device_frame:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_frame
#    path: ../flutter_device_preview/device_frame

Sorry, I don't get this. I can see two packages here: "device_preview" and "device_frame", you mean I should add both?

@Princewil
Copy link

Feel free to use this update by adding to your pubspec.yaml

dependency_overrides:
  device_preview:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_preview
#    path: ../flutter_device_preview/device_preview
  device_frame:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_frame
#    path: ../flutter_device_preview/device_frame

Sorry, I don't get this. I can see two packages here: "device_preview" and "device_frame", you mean I should add both?

Never mind. I got it now.
Thanks for the update.

@Dnathan33
Copy link
Contributor

Thanks for making the updates @bradrushworth. Good work!

@aloisdeniel I'd be happy to help in maintaining the project. I understand that it can be difficult for one person to maintain it all consistently. I'm already familiar with the project's codebase and I have two PRs already merged in.

@walid-ashik
Copy link

Thanks for making the updates @bradrushworth. Good work!

@aloisdeniel I'd be happy to help in maintaining the project. I understand that it can be difficult for one person to maintain it all consistently. I'm already familiar with the project's codebase and I have two PRs already merged in.

There's no activity in this project. can you fork it and create a separate project where we can all contribute? seems like this project is dead! :(

@yassine-bennkhay
Copy link

@bradrushworth Any idea on this issue?
Dialog widget is out of phone boundaries #175

@Nikzed
Copy link

Nikzed commented May 31, 2024

iPhone14Pro is not working here. Do not waste your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.