Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a few explicit tests on pitches #1801

Closed
wants to merge 1 commit into from
Closed

Add a few explicit tests on pitches #1801

wants to merge 1 commit into from

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Sep 28, 2022 •
edited
Loading

Depends on #1610.

@bernhardmgruber bernhardmgruber force-pushed the pitchtest branch 2 times, most recently from 62cb913 to 354af50 Compare September 30, 2022 09:43
bernhardmgruber
bernhardmgruber commented Sep 30, 2022
View reviewed changes
test/unit/mem/buf/src/PitchTest.cpp

checkBufferPitches(dev, alpaka::Vec{10}, alpaka::Vec{40});

constexpr auto pitch = 512;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, NVIDIA does not guarantee a row pitch anywhere. It is just internal magic of cudaMallocPitch. So this test may fail on some hardware at some point. I guess I should query the row pitch. Should we maybe add an alpaka function for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we cannot really do this either, because all we could do is call cudaMallocPitch, since that may even use a different pitch for each call. It may not even be dependent on the arguments.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rethink how to write this test. The pitch should not be set explicitly because this value is given implicitly.

@bernhardmgruber bernhardmgruber marked this pull request as ready for review September 30, 2022 12:08
@bernhardmgruber
Copy link
Member Author

PR #2093 will simplify how pitches work and a few similar tests. That should make this PR obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychocoderHPC psychocoderHPC psychocoderHPC left review comments

Assignees
No one assigned
Labels
Backend:CUDA Backend:Serial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @psychocoderHPC