Add a more comprehensible test for ViewSubView #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
reviewed
Aug 25, 2023
bernhardmgruber
force-pushed
the
add_subview_test
branch
2 times, most recently
from
7e0623b to
1065e34
Compare
bernhardmgruber
force-pushed
the
add_subview_test
branch
from
1065e34 to
8e13db3
Compare
|
Please ignore the failing TSAN test, this is fixed in #2103. |
j-stephan
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for
ViewSubViewthat I used to understand its behavior. I still think it makes a nice unit test as well, so here it is.