Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nvcc warnings #2118

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix nvcc warnings #2118

merged 1 commit into from
Sep 5, 2023

Conversation

bernhardmgruber
Copy link
Member

This fixes all nvcc warnings I have locally.

@j-stephan
Copy link
Member

Please remember to set the appropriate labels.

psychocoderHPC
psychocoderHPC previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@psychocoderHPC psychocoderHPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to solve the merge conflicts.

test/unit/math/src/mathLambda.cpp
@@ -7,7 +7,7 @@
// "On Windows, the enclosing parent function ("C_A_T_C_H_T_E_M_P_L_A_T_E_T_E_S_T_F_U_N_C_...") for an extended
// __host__
// __device__ lambda cannot have internal or no linkage"
#if(!defined(__NVCC__) || (defined(__NVCC__) && defined(__CUDACC_EXTENDED_LAMBDA__) && !BOOST_COMP_MSVC))
#if(!defined(__NVCC__) || (defined(__NVCC__) && defined(__CUDACC_EXTENDED_LAMBDA__) && !defined(_MSC_VER)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you switch from BOOST_COMP_MSVC to the native define?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because before this change, I got the warning that BOOST_COMP_MSVC was undefined and the compiler assumed 0. I could have included the Boost Predef headers instead, but since I know the MSVC macro, and we also use other vendor specific macros like __NVCC__, i just went with _MSC_VER.

@bernhardmgruber
Copy link
Member Author

Please remember to set the appropriate labels.

Yes mom ..

@j-stephan
Copy link
Member

The GitLab CI is experiencing internal server errors... I'll try to merge this on Monday when the CI can hopefully be restarted.

@bernhardmgruber
Copy link
Member Author

The GitLab CI is experiencing internal server errors... I'll try to merge this on Monday when the CI can hopefully be restarted.

@j-stephan any news?

@j-stephan
Copy link
Member

Sorry, I was at a CASUS event all day. I will look at it tomorrow.

@bernhardmgruber
Copy link
Member Author

Sorry, I was at a CASUS event all day. I will look at it tomorrow.

Ah right, forgot about that! I rebased the PR then, maybe that helps.

@psychocoderHPC psychocoderHPC merged commit 2830f36 into alpaka-group:develop Sep 5, 2023
19 checks passed
@bernhardmgruber bernhardmgruber deleted the fix_warnings branch September 5, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-stephan j-stephan j-stephan left review comments

@psychocoderHPC psychocoderHPC psychocoderHPC approved these changes

Assignees
No one assigned
Labels
Backend:CUDA Type:Warning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernhardmgruber @j-stephan @psychocoderHPC