prevent allocMappedBufIfSupported from accepting arbitrary Types as TPlatform
#2120
Conversation
|
@chaever Thanks for your first PR. We will have a look into it! |
include/alpaka/mem/buf/Traits.hpp
Outdated
| @@ -175,9 +177,10 @@ namespace alpaka | |||
| TPlatform const& platform, | |||
| TExtent const& extent = TExtent()) | |||
| { | |||
| if constexpr(hasMappedBufSupport<TPlatform>) | |||
| using PlatformForMappedAlloc = Platform<TPlatform>; | |||
There was a problem hiding this comment.
I would suggest
| using PlatformForMappedAlloc = Platform<TPlatform>; | |
| using Platform = alpaka::Platform<TPlatform>; |
if it works?
There was a problem hiding this comment.
See for example
There was a problem hiding this comment.
This should now be consistent with the other usages of the Platform-Trait, which all have the alpaka namespace prefixed.
include/alpaka/mem/buf/Traits.hpp
Outdated
| @@ -175,9 +177,10 @@ namespace alpaka | |||
| TPlatform const& platform, | |||
| TExtent const& extent = TExtent()) | |||
| { | |||
| if constexpr(hasMappedBufSupport<TPlatform>) | |||
| using PlatformForMappedAlloc = alpaka::Platform<TPlatform>; | |||
There was a problem hiding this comment.
can you use using Platform like everywhere else?
There was a problem hiding this comment.
That was the initial version, until this was pointed out.
There was a problem hiding this comment.
My assumption was wrong. Platform = Platform<T> doesn't trigger -Wshadow. So feel free to follow @fwyzard's suggestion.
There was a problem hiding this comment.
PlatformForMappedAlloc should now be replaced by Platform.
|
@chaever Could you please call |
chaever
force-pushed
the
check_TPltf_when_allocating_device_memory
branch
from
4156839 to
3709711
Compare
|
Can you do a |
…r a shadow warning
chaever
force-pushed
the
check_TPltf_when_allocating_device_memory
branch
from
3709711 to
a0ca64a
Compare
|
This branch should now be branching off from develop at 6b43b8d (most recent develop-commit at time of writing). |
This PR aims to resolve #2065.