CI: improve script utils #2323
Merged
CI: improve script utils #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonEhrig
force-pushed
the
CIsetupUtilitiesScript
branch
from
fc8c571 to
ade41b7
Compare
SimeonEhrig
force-pushed
the
CIsetupUtilitiesScript
branch
from
ade41b7 to
b6d0ddb
Compare
psychocoderHPC
approved these changes
Jul 24, 2024
fix and improve loading utility function in CI bash scripts - create `setup_utilities.sh` script to bundle several CI tools in one script - call `set` command in each script -> before if script was executed instead source `set -e` was not active and the script did not exit, if a failure happened - install sudo instead use fake_sudo.sh script, because it is more robust -> if an environment variable was directly set before the sudo command, fake_sudo.sh could not handle this - move installation of agc-manager to extra script, that will be also install on GitHub Actions (was not installed before, therefore using agc-manager always returns false) - suppress bash trace output, if `setup_utilities.sh` is sourced because it does not provide a benefit but spam the job output
SimeonEhrig
force-pushed
the
CIsetupUtilitiesScript
branch
from
b6d0ddb to
8ea7e38
Compare
psychocoderHPC
approved these changes
Jul 25, 2024
psychocoderHPC
added a commit
to psychocoderHPC/alpaka
that referenced
this pull request
Aug 6, 2024
With alpaka-group#2323 we broke the github pages CI job. ``` cd ${GITHUB_WORKSPACE} ./script/install_doxygen.sh ./script/setup_utilities/agc-manager.sh: line 3: ALPAKA_CI_OS_NAME: ALPAKA_CI_OS_NAME must be specified ```
Merged
psychocoderHPC
added a commit
to psychocoderHPC/alpaka
that referenced
this pull request
Aug 6, 2024
With alpaka-group#2323 we broke the github pages CI job. ``` cd ${GITHUB_WORKSPACE} ./script/install_doxygen.sh ./script/setup_utilities/agc-manager.sh: line 3: ALPAKA_CI_OS_NAME: ALPAKA_CI_OS_NAME must be specified ```
psychocoderHPC
added a commit
that referenced
this pull request
Aug 6, 2024
With #2323 we broke the github pages CI job. ``` cd ${GITHUB_WORKSPACE} ./script/install_doxygen.sh ./script/setup_utilities/agc-manager.sh: line 3: ALPAKA_CI_OS_NAME: ALPAKA_CI_OS_NAME must be specified ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix and improve loading utility function in CI bash scripts
setup_utilities.shscript to bundle several CI tools in one scriptsetcommand in each script -> before if script was executed instead sourceset -ewas not active and the script did not exit, if a failure happenedsetup_utilities.shis sourced because it does not provide a benefit but spam the job outputis ripped of PR #2315