Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in CI pipeline #2421

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

SimeonEhrig
Copy link
Member

  • before CPU jobs was put in the GPU pipeline and GPU jobs in the CPU pipeline
  • now it is switched
  • does not change anything at the tests -> only display bug

- before CPU jobs was put in the GPU pipeline and GPU jobs in the CPU pipeline
- now it is switched
- does not change anything at the tests -> only display bug
@@ -28,8 +28,8 @@ generate:
- pip3 install -r script/job_generator/requirements.txt
# it is sufficient to verify once, as the same job matrix is generated, verified and then filtered each time
# disable verify because we know that the generator is broken: https://github.com/thombashi/allpairspy/pull/10
# - python3 script/job_generator/job_generator.py ${ALPAKA_GITLAB_CI_GENERATOR_CONTAINER_VERSION} --verify --split-waves --wave-out-compile_only_job=compile_only.yml --wave-out-runtime_job_gpu=runtime_cpu.yml --wave-out-runtime_job_cpu=runtime_gpu.yml
- python3 script/job_generator/job_generator.py ${ALPAKA_GITLAB_CI_GENERATOR_CONTAINER_VERSION} --split-waves --wave-out-compile_only_job=compile_only.yml --wave-out-runtime_job_gpu=runtime_cpu.yml --wave-out-runtime_job_cpu=runtime_gpu.yml
# - python3 script/job_generator/job_generator.py ${ALPAKA_GITLAB_CI_GENERATOR_CONTAINER_VERSION} --verify --split-waves --wave-out-compile_only_job=compile_only.yml --wave-out-runtime_job_gpu=runtime_gpu.yml --wave-out-runtime_job_cpu=runtime_cpu.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this commented out part?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the current job generator has bugs and a hidden random number generator. Therefore I know, it will not produce all expected combinations each time and therefore the verify function is not working all the time.

bahsi will solved the problem.

@j-stephan j-stephan merged commit 075e88c into alpaka-group:develop Nov 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants