Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor private functions #684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LanderOtto
Copy link
Collaborator

This commit changes some functions from private to public because they were used across different files

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.44%. Comparing base (e2b5a8b) to head (4f422ce).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
streamflow/core/utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #684       +/-   ##
===========================================
- Coverage   71.47%   61.44%   -10.04%     
===========================================
  Files          88       88               
  Lines       11358    11360        +2     
  Branches     1985     1985               
===========================================
- Hits         8118     6980     -1138     
- Misses       2782     3930     +1148     
+ Partials      458      450        -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto force-pushed the refactor/removed_private_functions branch 2 times, most recently from d8c5b0c to 91b433e Compare February 28, 2025 20:01
@LanderOtto LanderOtto force-pushed the refactor/removed_private_functions branch 2 times, most recently from 4d1d892 to 767c69b Compare March 4, 2025 20:28
Fixed hint typing
Refactor `contains_entity_id` function
@LanderOtto LanderOtto force-pushed the refactor/removed_private_functions branch from 767c69b to 4f422ce Compare March 4, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant