Refactor command arguments in the Python traces #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanderOtto
force-pushed
the
refactor-args
branch
2 times, most recently
from
0c9d55c to
bfddb04
Compare
…it, the arguments from the port and the static arguments were two different list and merged together. Now, a list is used where each element is a tuple `bool` and `str`. The boolean indicates if the str is the name of a port.
LanderOtto
commented
Dec 23, 2024
| for i, arg in enumerate(step.arguments) | ||
| if isinstance(arg, Port) | ||
| arguments = [ | ||
| (arg.name, True) if isinstance(arg, Port) else (arg, False) |
There was a problem hiding this comment.
Suggested change
| (arg.name, True) if isinstance(arg, Port) else (arg, False) | |
| (arg.name, isinstance(arg, Port)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command changes the retrieval of the arguments in the Python traces. Before this commit, the arguments of the ports (e.g. data produced by a previous step) and the static one (e.g. the option flag of a command) were two different lists and merged together in the
_execfunction. Now, a list is used where each element is a tuplebooleanandstring. The boolean indicates if the string is the name of a port.