Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding light variant of gruvbox light and improving color mapping! :) #30

Open
wants to merge 1 commit into
base: multi-theme
Choose a base branch
from

Conversation

cal2195
Copy link
Contributor

@cal2195 cal2195 commented Oct 23, 2017

Made a section of light colors as most of the colors are different.

I'm gonna clean up the color names in the future if they aren't used elsewhere?

@alphapapa
Copy link
Owner

alphapapa commented Oct 23, 2017

Hey Cal,

You may want to break with the Solarized-based color organization here, the "baseX" names. Since we have each theme's files in its own directory, you can basically organize the colors however you want. In fact, using a colors.styl file is not strictly necessary, so you could e.g. put the dark-specific and light-specific colors in their own files.

I see that Gruvbox doesn't name them that way, so you don't have to force other themes into that scheme. So you could use the names it uses, like bg, bg0_h, fg, etc. In fact, I would recommend doing this, following the theme's native names and organization as much as possible, which makes it more straightforward to implement the variants.

@alphapapa alphapapa force-pushed the multi-theme branch 5 times, most recently from d3c1db4 to 9b63bf2 Compare October 24, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants