Skip to content

feat(linux, steamvr-launcher): Improve logging for gpu checks, add more checks, update wiki #4685

feat(linux, steamvr-launcher): Improve logging for gpu checks, add more checks, update wiki

feat(linux, steamvr-launcher): Improve logging for gpu checks, add more checks, update wiki #4685

Triggered via pull request January 18, 2025 22:44
Status Failure
Total duration 5m 10s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

8 errors and 3 warnings
check-linux: alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs#L98
error[E0308]: mismatched types --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:98:26 | 98 | linux_encoder_checks(&device_infos); | -------------------- ^^^^^^^^^^^^^ expected `&[DeviceInfo]`, found `&Vec<(&Adapter, DeviceInfo)>` | | | arguments to this function are incorrect | = note: expected reference `&[steamvr_launcher::linux_steamvr::DeviceInfo]` found reference `&std::vec::Vec<(&wgpu::Adapter, steamvr_launcher::linux_steamvr::DeviceInfo)>` note: function defined here --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:193:4 | 193 | fn linux_encoder_checks(device_infos: &[DeviceInfo]) { | ^^^^^^^^^^^^^^^^^^^^ ---------------------------
check-linux: alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs#L156
error[E0277]: the `?` operator can only be used in a function that returns `Result` or `Option` (or another type that implements `std::ops::FromResidual`) --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:156:60 | 101 | fn linux_gpu_checks(device_infos: &[(&wgpu::Adapter, DeviceInfo)]) { | ------------------------------------------------------------------ this function should return `Result` or `Option` to accept `?` ... 156 | let vrmonitor_path = alvr_server_io::steamvr_root_dir()? | ^ cannot use the `?` operator in a function that returns `()` | = help: the trait `std::ops::FromResidual<std::result::Result<std::convert::Infallible, alvr_common::anyhow::Error>>` is not implemented for `()` help: consider adding return type | 101 | fn linux_gpu_checks(device_infos: &[(&wgpu::Adapter, DeviceInfo)]) -> Result<(), Box<dyn std::error::Error>> { | +++++++++++++++++++++++++++++++++++++++++
check-linux: alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs#L159
error[E0277]: `std::path::PathBuf` doesn't implement `std::fmt::Display` --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:159:34 | 159 | debug!("vrmonitor_path: {}", vrmonitor_path); | ^^^^^^^^^^^^^^ `std::path::PathBuf` cannot be formatted with the default formatter; call `.display()` on it | = help: the trait `std::fmt::Display` is not implemented for `std::path::PathBuf` = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead = note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data = note: this error originates in the macro `$crate::__private_api::format_args` which comes from the expansion of the macro `debug` (in Nightly builds, run with -Z macro-backtrace for more info)
check-linux: alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs#L168
error[E0277]: `std::path::PathBuf` doesn't implement `std::fmt::Display` --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:168:85 | 168 | VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/nvidia_icd.json {} %command%", vrmonitor_path); | ^^^^^^^^^^^^^^ `std::path::PathBuf` cannot be formatted with the default formatter; call `.display()` on it | = help: the trait `std::fmt::Display` is not implemented for `std::path::PathBuf` = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead = note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data = note: this error originates in the macro `$crate::__private_api::format_args` which comes from the expansion of the macro `warn` (in Nightly builds, run with -Z macro-backtrace for more info)
check-linux: alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs#L176
error[E0277]: `std::path::PathBuf` doesn't implement `std::fmt::Display` --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:176:47 | 176 | warn!("DRI_PRIME=1 {} %command%", vrmonitor_path); | ^^^^^^^^^^^^^^ `std::path::PathBuf` cannot be formatted with the default formatter; call `.display()` on it | = help: the trait `std::fmt::Display` is not implemented for `std::path::PathBuf` = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead = note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data = note: this error originates in the macro `$crate::__private_api::format_args` which comes from the expansion of the macro `warn` (in Nightly builds, run with -Z macro-backtrace for more info)
check-linux: alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs#L188
error[E0277]: `std::path::PathBuf` doesn't implement `std::fmt::Display` --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:188:13 | 188 | vrmonitor_path | ^^^^^^^^^^^^^^ `std::path::PathBuf` cannot be formatted with the default formatter; call `.display()` on it | = help: the trait `std::fmt::Display` is not implemented for `std::path::PathBuf` = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead = note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data = note: this error originates in the macro `$crate::__private_api::format_args` which comes from the expansion of the macro `warn` (in Nightly builds, run with -Z macro-backtrace for more info)
check-linux
Process completed with exit code 101.
check-msrv-linux
Process completed with exit code 101.
check-linux: alvr/graphics/src/stream.rs#L227
warning: unsafe function's docs are missing a `# Safety` section --> alvr/graphics/src/stream.rs:227:5 | 227 | pub unsafe fn render(&self, hardware_buffer: *mut c_void, view_params: [StreamViewParams; 2]) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
check-linux: alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs#L2
warning: unused import: `std::path::PathBuf` --> alvr/dashboard/src/steamvr_launcher/linux_steamvr.rs:2:5 | 2 | use std::path::PathBuf; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
check-windows: alvr/graphics/src/stream.rs#L227
warning: unsafe function's docs are missing a `# Safety` section --> alvr\graphics\src\stream.rs:227:5 | 227 | pub unsafe fn render(&self, hardware_buffer: *mut c_void, view_params: [StreamViewParams; 2]) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default