refactor: ⬆️ Upgrade egui and other deps #566
zmerp
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
1 error and 7 warnings
|
cannot borrow `installation_dir` as mutable, as it is not declared as mutable:
alvr/launcher/src/main.rs#L768
error[E0596]: cannot borrow `installation_dir` as mutable, as it is not declared as mutable
--> alvr/launcher/src/main.rs:768:13
|
768 | installation_dir.push("ALVR-x86_64.AppImage");
| ^^^^^^^^^^^^^^^^ cannot borrow as mutable
|
help: consider changing this to be mutable
|
761 | let mut installation_dir = data_dir().extended(VERSIONS_SUBDIR).extended(&release.tag);
| +++
|
|
wiki
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, cmbrose/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
unused variable: `ui`:
alvr/dashboard/src/dashboard/components/setup_wizard.rs#L128
warning: unused variable: `ui`
--> alvr/dashboard/src/dashboard/components/setup_wizard.rs:128:18
|
128 | |ui| {
| ^^ help: if this is intentional, prefix it with an underscore: `_ui`
|
= note: `#[warn(unused_variables)]` on by default
|
|
the borrowed expression implements the required traits:
alvr/launcher/src/main.rs#L763
warning: the borrowed expression implements the required traits
--> alvr/launcher/src/main.rs:763:24
|
763 | fs::create_dir_all(&installation_dir)?;
| ^^^^^^^^^^^^^^^^^ help: change this to: `installation_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
unused variable: `buffer`:
alvr/launcher/src/main.rs#L759
warning: unused variable: `buffer`
--> alvr/launcher/src/main.rs:759:9
|
759 | let buffer = download(tx, "Downloading Streamer", &url, client).await?;
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable expression:
alvr/launcher/src/main.rs#L782
warning: unreachable expression
--> alvr/launcher/src/main.rs:782:5
|
765 | / match installation_type {
766 | | #[cfg(target_os = "linux")]
767 | | InstallationType::AppImage => {
768 | | installation_dir.push("ALVR-x86_64.AppImage");
... |
780 | | }
781 | | }
| |_____- any code following this `match` expression is unreachable, as all arms diverge
782 | Ok(())
| ^^^^^^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
|
|
unused import: `Permissions`:
alvr/launcher/src/main.rs#L6
warning: unused import: `Permissions`
--> alvr/launcher/src/main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused import: `Permissions`:
alvr\launcher\src\main.rs#L6
warning: unused import: `Permissions`
--> alvr\launcher\src\main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|