feat(dashboard): 🔊 Display requests in json form on debug #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,7 +103,10 @@ impl DataSources { | |||
|
|
|||
| while running.value() { | |||
| while let Ok(request) = requests_receiver.try_recv() { | |||
| debug!("Dashboard request: {request:?}"); | |||
| debug!( | |||
There was a problem hiding this comment.
This should not be under some debug group, so it can be disabled because this seems really annoying. Or rather under the raw events or spammy events stuff.
There was a problem hiding this comment.
This is the dashboard, it doesn't have the debug groups. In release builds, debug log is not shown. The reason for this is ease of discovery of the webserver API.
There was a problem hiding this comment.
I think we should come back to this after the patch release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.