Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Android launcher icon #2668

Merged
merged 1 commit into from
Jan 31, 2025
Merged

chore: Add Android launcher icon #2668

merged 1 commit into from
Jan 31, 2025

Conversation

curoviyxru
Copy link
Contributor

No description provided.

zmerp
zmerp approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks good. It's slightly different than the one I uploaded for the meta store, there is a difference in size, but yours looks much sharper (the one I published is a png instead of svg, and meta might have messed up the resolution scaling)

@curoviyxru
Copy link
Contributor Author

I converted ALVR-Icon.svg into adaptive vector icon and resized it to fit icon "safe zone" with Android Studio, that's all. It also would be cool to specify icon for activity, but cargo-apk doesn't seem to support it sadly.

@zmerp
Copy link
Member

zmerp commented Jan 30, 2025

That's alright, I'm good for current state

@zmerp zmerp merged commit 68a951e into alvr-org:master Jan 31, 2025
8 checks passed
@curoviyxru curoviyxru deleted the launcher-icon branch February 2, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerp zmerp zmerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curoviyxru @zmerp