You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Besides these obvious bugs, I'm also unsure that the add_copyright_year function should parse the copyright comments.
the parsed data should already be available in the descriptor objects.
fixing these bugs should be easy.
however, it looks like the tool supports multiple copyrights. How do we deal with them?
The
ament_copyright --add-copyright-year
tool is currently broken.this attribute should be named
copyright_identifiers
(with ans
at the end)the function
search_copyright_information
returns 2 values, not 3Besides these obvious bugs, I'm also unsure that the
add_copyright_year
function should parse the copyright comments.the parsed data should already be available in the descriptor objects.
fixing these bugs should be easy.
however, it looks like the tool supports multiple copyrights. How do we deal with them?
Let's say that I have a file with 2 copyrights
IMO we should have the tool update only the latest copyright (or maybe the first one found in the document)
The text was updated successfully, but these errors were encountered: