Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add-copyright year function #466

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Fix add-copyright year function #466

merged 2 commits into from
Mar 3, 2024

Conversation

superdyoll
Copy link
Contributor

@superdyoll
Fix add-copyright year function
64e4a78 
* Fixes bug raised in
  [ament#414](ament#414)

Signed-off-by: superdyoll <[email protected]>
@superdyoll superdyoll force-pushed the superdyoll/fix-add-copyright-year branch from 6d655f1 to 64e4a78 Compare January 8, 2024 11:46
@superdyoll superdyoll mentioned this pull request Jan 8, 2024
Open
@superdyoll
Copy link
Contributor Author

@clalancette is there anything you'd like me to change, or are you happy to merge this?

clalancette
clalancette requested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, this looks great. I've left one comment to cleanup; once we do that, I'm happy to approve and run CI on it.

ament_copyright/ament_copyright/main.py Outdated Show resolved Hide resolved
@superdyoll
Remove debugging code
78e5415 
Signed-off-by: superdyoll <[email protected]>
@superdyoll superdyoll force-pushed the superdyoll/fix-add-copyright-year branch from 474fa9c to 78e5415 Compare February 19, 2024 15:12
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 2d4f46c into ament:rolling Mar 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superdyoll @clalancette