Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_uncrustify is incompatible with uncrustify >= 0.75 #440

Open
cottsay opened this issue May 26, 2023 · 1 comment
Open

ament_uncrustify is incompatible with uncrustify >= 0.75 #440

cottsay opened this issue May 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cottsay
Copy link
Contributor

cottsay commented May 26, 2023

Uncrustify 0.75 introduces changes to the configuration format which are not compatible with the configuration hard-coded into ament_uncrustify.

RHEL 9 packages uncrustify-0.75.1. The only reason we don't have broken builds on ci.ros2.org is that uncrustify_vendor's detection logic is broken and we're vendoring 0.72.

My first suggestion to address this was to set an upper bound on our Uncrustify version for vendoring, but @clalancette prefers that we address the problem here.

@clalancette
Copy link
Contributor

@sloretz mentions that maybe we should just unconditionally vendor the linter, since it needs to be the same on all platforms. It's not a terrible idea, and would fix this problem, so maybe that is a way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants