Vendor uncrustify when system has >= 0.75

[cottsay]

This version of uncrustify introduces changes to the configuration file which are not backwards compatible with older configuraitons, causing all invocations of ament_uncrustify to fail.

• Linux
• Linux-aarch64
• Windows

[clalancette]

I've got a couple of different thoughts about this.

First, I was wondering why we needed this at all, given that RHEL-9 has uncrustify 0.75 and seems to be green on the buildfarm. But looking closer, it looks like we are unconditionally vendoring uncrustify 0.72 on RHEL-9 through a mechanism I don't understand. Should we look into this and fix it?

Second, this is kicking the can down the road. We are probably going to have to deal with this problem for Ubuntu 24.04 anyway. So should we have ament_uncrustify attempt to detect the version and use the appropriate configuration file instead?

[cottsay]

Should we look into this and fix it?

Already addressed in #32.

Second, this is kicking the can down the road.

My aim is to get the bug in #32 fixed without regressing RHEL 9, and this is the lowest effort path to do that. Forking the config might be a reasonable thing to do - maybe we should engage the ament_lint maintainers about that.

[clalancette]

My aim is to get the bug in #32 fixed without regressing RHEL 9, and this is the lowest effort path to do that. Forking the config might be a reasonable thing to do - maybe we should engage the ament_lint maintainers about that.

Yeah, I'll suggest we attempt to do this. We still have time before the freeze, and I think it would fall under the "bug fix" category anyway.

[cottsay]

Yeah, I'll suggest we attempt to do this. We still have time before the freeze, and I think it would fall under the "bug fix" category anyway.

So should we wait to merge #32 until ament_cppcheck can handle it, or regress the cppcheck test results in RHEL 9 for the time being?

[clalancette]

So should we wait to merge #32 until ament_cppcheck can handle it, or regress the cppcheck test results in RHEL 9 for the time being?

I'd prefer if we keep things green, so I'd say let's hold off on that one until we have the real solution in place.

[cottsay]

Tracking this in ament_lint as ament/ament_lint#440.