Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(dependencies): override chokidar 2 with 3 #1381

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

PixnBits
Copy link
Contributor

Description

Override chokidar under @americanexpress/one-app-server-bundler from 2.x to 3.x

Motivation and Context

Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies

https://www.npmjs.com/package/chokidar/v/2.1.8

a few dependencies of chokidar@^2 have similar deprecation messages

How Has This Been Tested?

PR checks

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

This might affect users building this one-app server in watch mode, but any impacts are highly unlikely as the breaking change in chokidar 3 was dropping support for Node.js versions before 8.x
https://github.com/paulmillr/chokidar/releases/tag/3.0.0

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Size Change: 0 B

Total Size: 735 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 187 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 124 kB

compressed-size-action

@10xLaCroixDrinker 10xLaCroixDrinker enabled auto-merge (squash) April 12, 2024 18:07
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 489d987 into main Apr 12, 2024
9 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/override-chokidar branch April 12, 2024 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants