Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Refactor/upgrading to node 20 11 0 #1385

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.11.0]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.17.1
20.11.0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG VERSION=lts
ARG VERSION=20.11.0
# Use the pre-baked fat node image only in the builder
giulianok marked this conversation as resolved.
Show resolved Hide resolved
# which includes build utils preinstalled (e.g. gcc, make, etc).
# This will result in faster and reliable One App docker image
Expand Down
2 changes: 1 addition & 1 deletion one-app-statics/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@americanexpress/one-app-statics",
"version": "6.12.1",
"version": "6.13.0-node-20-11-0.0",
"description": "One App Static Assets",
"main": "index.js",
"scripts": {
Expand Down
5,294 changes: 3,181 additions & 2,113 deletions package-lock.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "@americanexpress/one-app",
"version": "6.12.1",
"version": "6.13.0-node-20-11-0.0",
"description": "One Amex SPA technology stack.",
"main": "index.js",
"engines": {
"node": ">=18 <=20",
"npm": ">=8"
"node": ">=18 <=20.11.0",
"npm": ">=9"
},
"scripts": {
"preinstall": "npx check-engines@1",
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG VERSION=lts
ARG VERSION=20.11.0

giulianok marked this conversation as resolved.
Show resolved Hide resolved
FROM node:$VERSION as builder
MAINTAINER One App Team
Expand Down
Loading