Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lint): fix lint error after building #55

Closed
wants to merge 1 commit into from

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Nov 7, 2024

Description

Do not lint the immutable.js file in the root.

Motivation and Context

The immutable.js file imports a file from the lib dir. This causes a lint paradox:

  • If the lib dir doesn't exist, then eslint throws an error that you are importing from a non-existent thing.
  • If you add a comment that says that's okay (what is in the code now), then eslint is happy again.
  • But now if you run a build, it will create the lib dir, and now there is no eslint error, and eslint complains you are disabling a rule for no reason.

So the easiest fix is to just not lint that file.

Other alternative fixes would be:

  • Disable the two failing rules entirely.
  • Run the clean script before the lint script, to ensure that lib dir isn't there.

How Has This Been Tested?

Verified no eslint errors both when lib dir exists and doesn't exist.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for vitruvius users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using vitruvius?

None.

Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity.

@smackfu
Copy link
Member Author

smackfu commented Dec 23, 2024

Assume this is mooted by #57

@smackfu smackfu closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants