Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): disable the navigation buttons if their actions are not possible #224

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

akriese
Copy link
Contributor

@akriese akriese commented Jan 18, 2024

This is not connected to any ticket, but was briefly mentioned in our team meeting.

I did a little refactor of the ThumbnailCache on the side :)

This refactors the jumpToNextDiff() on the side to be
more readable. Uses a more functional approach now.

Signed-off-by: Anton Kriese <[email protected]>
@akriese akriese requested review from a team and fs3itz and removed request for a team January 18, 2024 16:50
@akriese akriese marked this pull request as draft January 18, 2024 17:18
@akriese akriese requested a review from zino212 January 20, 2024 09:03
@akriese akriese marked this pull request as ready for review January 20, 2024 09:04
Copy link
Contributor

@zino212 zino212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works on my machine! :)

@akriese akriese merged commit 0f2f260 into main Jan 20, 2024
8 checks passed
@akriese akriese deleted the gui/feature/disable-nav-buttons branch January 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants