feat: add cases of facility to frontend #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ingo Sternberg <[email protected]> #250
4 tasks
Signed-off-by: Ingo Sternberg <[email protected]> #250
Signed-off-by: Ingo Sternberg <[email protected]> #250
Signed-off-by: Ingo Sternberg <[email protected]> #250
Co-authored-by: Ingo Sternberg <[email protected]> Signed-off-by: Alexander Lorenz <[email protected]>
Hydraneut
approved these changes
Jul 12, 2024
HaruspexSan
reviewed
Jul 12, 2024
libs/cases/frontend/view/src/lib/components/create-case/create-case.component.spec.ts
Show resolved
Hide resolved
libs/cases/frontend/view/src/lib/components/case-browse/case-browse.component.html
Show resolved
Hide resolved
|
It is .length because cases is an array and to get the length of it you do .length |
HaruspexSan
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed the routing of the goBack Button to use location.back(). I first thought just cutting the current url until the / would be the best but location.back() is actually better.
It goes back to the last page so now if you click on view 3rd case and go back you are redirected back to the details page where you came from
Signed-off-by: Ingo Sternberg [email protected]
#250